Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrumentation tests coverage fix #358

Open
ekigamba opened this issue Aug 23, 2022 · 0 comments
Open

Instrumentation tests coverage fix #358

ekigamba opened this issue Aug 23, 2022 · 0 comments

Comments

@ekigamba
Copy link
Contributor

ekigamba commented Aug 23, 2022 •
edited
Loading

This issue came up after updating AGP in this PR

Reduced coverage by 10%

  • Jacoco has a known bug that results in no coverage generation when buildType.debug.testCoverageEnabled is set to true. With this option set to false, gradle does not find the task 'createDebugCoverageReport which is used to run instrumentation tests with coverage reporting. These tests contribute to a fraction of the
    test coverage.

Below is the difference especially in the sample module where the tests are mostly instrumentation tests
Screenshot from 2022-08-22 18-11-48
Before

Screenshot from 2022-08-22 18-11-38
After
@ekigamba ekigamba mentioned this issue Aug 23, 2022
Merged
ekigamba added a commit that referenced this issue Sep 6, 2022
@ekigamba
Add instrumentation tests workaround
3f45be0 
- Enable testCoverage only for instrumentation tests and disable the flag after
- Add the path for the new instrumentation test coverage ec file

Relates to #358
@ekigamba ekigamba mentioned this issue Sep 6, 2022
Draft
ekigamba added a commit that referenced this issue Sep 6, 2022
@ekigamba
Add instrumentation tests workaround
4e2400b 
- Enable testCoverage only for instrumentation tests and disable the flag after
- Add the path for the new instrumentation test coverage ec file

Relates to #358
ekigamba added a commit that referenced this issue Sep 6, 2022
@ekigamba
Add instrumentation tests workaround
7dead40 
- Enable testCoverage only for instrumentation tests and disable the flag after
- Add the path for the new instrumentation test coverage ec file

Relates to #358
ekigamba added a commit that referenced this issue Sep 6, 2022
@ekigamba
Add instrumentation tests workaround
5eb8bbc 
- Enable testCoverage only for instrumentation tests and disable the flag after
- Add the path for the new instrumentation test coverage ec file

Relates to #358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ekigamba