Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]:Mobile Navigation Box Does Not Automatically Close When Navigating #133

Closed
Sujal7ss opened this issue May 19, 2024 · 4 comments · Fixed by #151
Closed

[BUG]:Mobile Navigation Box Does Not Automatically Close When Navigating #133

Sujal7ss opened this issue May 19, 2024 · 4 comments · Fixed by #151
Assignees
Labels

Comments

@Sujal7ss
Copy link
Contributor

I encountered an issue where the navigation box in the mobile view did not automatically close when navigating through any navigation items. This behavior is undesirable as it obstructs the user's view of the content after selecting a navigation option.

Steps to Reproduce:

  1. Open the application in a mobile viewport.
  2. Click on a navigation item to navigate to a different section/page.
  3. Observe that the navigation box remains open, obscuring the content of the page.
  4. Expected Behavior:
  5. When a navigation item is clicked in the mobile view, the navigation box should automatically close to provide an unobstructed view of the content.

Actual Behavior:
The navigation box does not close automatically after navigating to a different section/page in the mobile view.

Solution:
To address this issue, we need to add functionality to the Navigation component to automatically close the navigation box when a navigation item is clicked in the mobile view. This can be achieved by utilizing a function to toggle the visibility of the navigation box and calling this function when a navigation item is clicked.

@omrajsharma please add GSSOC label and level to it.
I am a GSSOC contributor and i have already solved this issue. Please assign it to me and i will make a PR.
a

v
Copy link

Hi there! Thanks for opening this issue. We appreciate your contribution to this open-source project. We aim to respond or assign your issue as soon as possible.

@abhiperfect
Copy link
Collaborator

Hi @Sujal7ss , Good to know you find a bug, i am assigning this issue to you.

@abhiperfect abhiperfect changed the title Mobile Navigation Box Does Not Automatically Close When Navigating [BUG]:Mobile Navigation Box Does Not Automatically Close When Navigating May 19, 2024
@Sujal7ss
Copy link
Contributor Author

Facing some issues @abhiperfect
Every changes i have made are wroking fine on my end.
Please review my commits

@Sujal7ss
Copy link
Contributor Author

@abhiperfect All the errors are resolved. Please check the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants