-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open repo_button nav link in a new tab/window #846
Comments
Generally I think this might be something to use an edited "nav" fragment as a custom fragment. Happy to discuss this so. |
I'm not sure I fully understand; would this mean all non-content/markdown links would be configurable with a target? In fact, I think this would be a good thing, as long as the default is leaving it unset. For the repo link in particular, one could even argue to make it |
Adding that option multiplies the varieties of the options and complicates the code as well. Currently my stance is that the complexity for that specific feature isn't warranted especially as once can duplicate the navigation fragment and add it in as a custom fragment instead. |
Is this a BUG REPORT or FEATURE REQUEST?:
feature
What happened: repo_button links open in the same tab.
What you expected to happen: It would be nice to be able to specify if they should be opened in a new tab/window (i.e. target=_blank).
How to reproduce it (as minimally and precisely as possible):
Configure a repo_button on a "nav" fragment, then click it.
Environment:
The text was updated successfully, but these errors were encountered: