Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] What should the polyfill do with disabled style/link elements? #247

Closed
jgerigmeyer opened this issue Sep 13, 2024 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@jgerigmeyer
Copy link
Member

This was raised in #242 and #243.

Right now the polyfill parses and replaces a disabled style or link element. In the case of a link element, it gets replaced with a non-disabled, polyfilled version. This is clearly a bug.

One option would be to skip parsing of disabled stylesheets, but then we may want to watch and parse them if they become un-disabled?

Another option would be to parse them, but replace the link with another disabled link. This is easier to implement, and ensures that if the stylesheet is later un-disabled then the polyfilled styles would be loaded.

@jgerigmeyer jgerigmeyer added the bug Something isn't working label Sep 13, 2024
@jgerigmeyer
Copy link
Member Author

jgerigmeyer commented Sep 13, 2024

Closing, replaced by #246.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant