-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow messaging grouped nicks #93
Comments
We would still need to make sure the user is authenticated, since it's possible to have a nick without being authenticated (though ChanServ won't let you keep this for very long). Dealing with grouped nicks makes this even more complicated, since now there are multiple IRC users we might want to route a Slack PM to. It could break continuity with multiple nicks. I'm not sure we could make this work in a way that's consistent, but I'm open to ideas. |
I think it should send your message to the exact nick you specify. As far as making sure the user is authenticated, we won't get a 307 message until the user has authenticated. I tested this. |
It shouldn't send the message unless the user really is authenticated, otherwise someone could steal messages in the case I mentioned above. |
307 is sufficient to know that the user really is authenticated. Am I missing something? |
Ohhhh I misread what this is saying, I think you're good, sorry for the confusion |
The current PM delivery logic checks that the nick matches the user that's authenticated with nickserv. We should just check that the nick is registered (307).
The text was updated successfully, but these errors were encountered: