Add pytest for utils

[kkuehlz]

Since the slackbridge is arguably becoming one of the most important internal ocf projects we should add unit tests for utils and, where possible, move more functionality that can be tested into utils.

We can also add one of those fancy coverage buttons to the project too.

[abizer]

perhaps we can also generalize the slackbridge and offer it to the wider community for people with similar setups as us.

[ethanhs]

perhaps we can also generalize the slackbridge and offer it to the wider community for people with similar setups as us.

I think that deserves a separate issue, or ten.

We can also add one of those fancy coverage buttons to the project too.

Research has found that coverage testing isn't particularly effective at finding bugs. So while it has a nice badge, it would be much more effective to add type checking. Mypy has a fancy badge too now :)

[kkuehlz]

@ethanhs I agree. And while I definitely think any future OCF project (or even new python scripts in puppet) could benefit from type checking, I don't really feel like doing this for slackbridge.

I do think we are getting slightly off topic. We should create new issues for both of these concerns.

[dkess]

I'm thinking of closing this issue, since we do now have type checking in slackbridge, and I am skeptical that we would be able to write good unit tests for this. Anyone else have thoughts?

[kkuehlz]

Types are orthogonal to unit tests. The unit tests would just be for the utils file, which we would be able to write good tests for. We can easily write tests for irc message formatting, nick stripping, etc.

It's not high priority. But i dont see any benefit in closing the issue