Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meeting-hours API to support edge cases #242

Open
ben9583 opened this issue Feb 17, 2022 · 0 comments
Open

Update meeting-hours API to support edge cases #242

ben9583 opened this issue Feb 17, 2022 · 0 comments
Assignees

Comments

@ben9583
Copy link
Member

ben9583 commented Feb 17, 2022

Looking at the potential meeting times for this semester, it's looking like Web and DDR committees may meet at the same time and Finance is meeting every other week, neither of which are supported by our current meeting-hours API. Even if the former doesn't happen, it's still good to make sure we can handle this for the future.

For conflicting meeting times, we'll probably just have /api/meetings/current and /api/meetings/next return a Listpopulated by all the same date-and-time meetings instead of returning a single meeting. Should be no need to change /api/meetings/list.

As for biweekly meetings (or n-weekly meetings, for that matter), not sure how we'll keep track of off-and-on weeks, especially considering school breaks, but we'll probably also have to update schemas/meeting_hours.json and configs/meeting_hours.yaml in etc.

Anyway, I'll probably work on this myself and make a pr in both repos when that's figured out.

Relevant etc issue: ocf/etc#344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant