Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use coherency index directly (instead of convexity deficiency) for RCLV boundary criterion #68

Open
rabernat opened this issue Aug 2, 2018 · 2 comments

Comments

@rabernat
Copy link
Collaborator

rabernat commented Aug 2, 2018

The current algorithm searches for a level curve of LAVD with a specified convexity-deficiency threshold to define the outer boundary of the RCLV.

As discussed with @pittwolfe and Wenda (can't find his github handle), it would be cool to have the option to use coherency index directly (instead of CD) for the boundary.

@geosciz
Copy link
Contributor

geosciz commented Aug 4, 2018

Hi @rabernat, in terms of the robustness of floater package itself, should it a better choice to make our searching algorithm independent of the coherency index? I mean a certain index is not perfectly defined and has its own strengths and weaknesses.

@pittwolfe
Copy link

We've found that using the coherency index by itself tends to detect rather large, non-compact eddies with very large convexity deficiencies. This is due to the normalization by the initial spread of the particles—the search algorithm can get arbitrary small negative negative values of the coherency index by including lots of particles. A pathological example would be simply counting all the particles in a closed or periodic domain as an "eddy". The particles can never leave and, if the flow is non-divergent, they can't bunch up or spread out, so the coherency index remains close to zero for all time. It never seems to get that bad in practice, but I don't see how to avoid detecting large, non-convex "eddies" without falling back on the convexity deficiency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants