-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of Windows paths #762
Comments
Thanks for bringing up this issue, @talex5 I agree that we need to improve how Eio handles Windows paths. Right now, using relative paths with the / separator works for some cases, but we have issues with absolute paths on Windows that need fixing. Things to Consider:
Next Steps: Community Input: I’d love to hear any ideas from others on how we can solve this. I’m looking forward to working together to improve Windows path support in Eio! |
Apologies for the misleading feedback I shared. Absolute paths never came up in Flow (in practice, all paths are relative to the process's working directory) and I wasn't aware that Windows APIs don't support |
@samwgoldman not misleading at all; it was very useful to know we could ship 1.0 like that. I just tagged you in case you objected to a change of direction, but I think it won't affect you either way. |
In #124, @samwgoldman said:
However, Eio also needs to support absolute paths on Windows and it seems this doesn't work (see https://discuss.ocaml.org/t/how-to-specify-a-full-windows-path-in-eio/14880). It would be good to investigate why.
@dra27 commented:
As mentioned in the original issue:
I think we should give up on a uniform representation of paths and instead move some operations (e.g.
split
) toFs.Pi.DIR
, so that each file-system can provide its own implementation.The text was updated successfully, but these errors were encountered: