Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If client_id is invalid and req.query.allowed = false, please throw InvalidClientError instead of AccessDeniedError #698

Open
chaudhryjunaid opened this issue Jun 10, 2021 · 0 comments

Comments

@chaudhryjunaid
Copy link

chaudhryjunaid commented Jun 10, 2021

Oauth recommends not redirecting to redirect_uri in case of invalid client. However, in case of req.query.allowed === 'false', client is not checked at all and an AccessDeniedError is thrown immediately. In AccessDeniedError I want to redirect to redirect uri but oauth2-server has not checked client uri at all. Kindly change the order of checking and throwing errors. InvalidClientError is a higher priority error than AccessDeniedError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant