storybook #21
Open
storybook #21
+34,969
−8,564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so it can use cjs while we use esm idea from storybookjs/storybook#11587 (comment)
danielgamage
changed the base branch from
main
to
feat/web-component-style-inheritance
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think this is useful for documentation if we host the storybook, but what i've done doesn't solve our web component CI testing.
it's using @storybook/html which is ok for the web component stories, but dynamic updates do full
story.innerHTML = newHtml-type updates which isn't ideal for interactive stuff (over-rendering and<script>tags need some special handling)