Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings when compiling with Qt 5.15 #77

Open
ahndee opened this issue May 27, 2020 · 2 comments · Fixed by maxwell130631/SortFilterProxyModel#1, CasparKielwein/SortFilterProxyModel#1 or milosolutions/SortFilterProxyModel#1 · May be fixed by #81
Open

Deprecation warnings when compiling with Qt 5.15 #77

ahndee opened this issue May 27, 2020 · 2 comments · Fixed by maxwell130631/SortFilterProxyModel#1, CasparKielwein/SortFilterProxyModel#1 or milosolutions/SortFilterProxyModel#1 · May be fixed by #81

Comments

@ahndee
Copy link

ahndee commented May 27, 2020

Qt 5.15 deprecated the comparison operators (<,>,<=,>=) for QVariant (see official documentation) which are used in rangefilter.cpp and rolesorter.cpp, resulting in compile-time warnings.
@timangus
Copy link
Contributor

Perhaps QSortFilterProxyModel::lessThan or the implementation of QAbstractItemModelPrivate::isVariantLessThan is useful here?

@TheCompez
Copy link

It is better to solve this problem before it causes more serious problems!

olafmandel added a commit to MenloSystems/SortFilterProxyModel that referenced this issue Oct 27, 2020
@olafmandel
Implement own lessThan(QVariant, QVariant)
0c5917e 
Qt 5.15 deprecated the operator<(QVariant, QVariant). Do get rid of the
warning and to prepare for the eventual removal of the operator,
implement our own needs in a lessThan() function.

The function is based on the description of
QSortFilterProxyModel::lessThan().

Fixes oKcerG#77
@olafmandel olafmandel linked a pull request Oct 27, 2020 that will close this issue
Open
olafmandel added a commit to MenloSystems/SortFilterProxyModel that referenced this issue Oct 27, 2020
@olafmandel
Implement own lessThan(QVariant, QVariant)
c7b853d 
Qt 5.15 deprecated the operator<(QVariant, QVariant). Do get rid of the
warning and to prepare for the eventual removal of the operator,
implement our own needs in a lessThan() function.

The function is based on the description of
QSortFilterProxyModel::lessThan().

Fixes oKcerG#77
@maxwell130631 maxwell130631 mentioned this issue Jan 19, 2021
Merged
@CasparKielwein CasparKielwein mentioned this issue Nov 7, 2021
Merged
@nsajko nsajko mentioned this issue Jan 4, 2022
Closed
@ghost ghost mentioned this issue Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ahndee @timangus @TheCompez