Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Update README's to reflect that building uses o1js instead of Mina #230

Open
MartinMinkov opened this issue Jan 2, 2024 · 4 comments
Open

Documentation: Update README's to reflect that building uses o1js instead of Mina #230

MartinMinkov opened this issue Jan 2, 2024 · 4 comments
Assignees
@MartinMinkov

Comments

@MartinMinkov
Copy link
Contributor

There is stale documentation such as this file, that needs to be updated to make mention of o1js being the root project to build from now.
@MartinMinkov MartinMinkov self-assigned this Jan 2, 2024
@shimkiv
Copy link
Member

shimkiv commented Jan 26, 2024

Also will be good to replace snarkyjs with o1js: https://github.com/search?q=repo%3Ao1-labs%2Fo1js-bindings%20snarkyjs&type=code
(including sub-modules inversion description)

@shimkiv
Copy link
Member

shimkiv commented Jan 26, 2024

There also files left with old name like build-snarkyjs...

@MartinMinkov
Copy link
Contributor Author

There also files left with old name like build-snarkyjs...

Which files are you referring to? In the bindings repo, I only see mention of snarkyjs inside README documentation

@shimkiv
Copy link
Member

shimkiv commented Jan 27, 2024

Oh my apologies I was using old reference in o1js. No files, only readme indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinMinkov MartinMinkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shimkiv @MartinMinkov