Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -ignore-md5-sum flag #88

Closed
wants to merge 1 commit into from

Conversation

mzealey
Copy link

@mzealey mzealey commented Sep 15, 2023

Per #87, S3 often generates ETag differently from pure MD5 hash which means that database entries are not cleared.

Per nyaruka#87, S3 often generates ETag differently from pure MD5 hash which
means that database entries are not cleared.
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #88 (048df1a) into main (10ead26) will decrease coverage by 47.55%.
Report is 4 commits behind head on main.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main      #88       +/-   ##
===========================================
- Coverage   68.00%   20.45%   -47.55%     
===========================================
  Files           6        6               
  Lines        1222     1222               
===========================================
- Hits          831      250      -581     
- Misses        286      938      +652     
+ Partials      105       34       -71     
Files Changed Coverage Δ
archives/config.go 100.00% <ø> (ø)
archives/messages.go 10.91% <0.00%> (-52.88%) ⬇️
archives/runs.go 10.22% <0.00%> (-40.91%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mzealey mzealey mentioned this pull request Sep 26, 2023
@rowanseymour
Copy link
Member

Closed in favor of #90

@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants