Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages in lock tests are not descriptive #759

Open
carpawell opened this issue Mar 27, 2024 · 1 comment
Open

Error messages in lock tests are not descriptive #759

carpawell opened this issue Mar 27, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers I4 No visible changes S4 Routine U3 Regular

Comments

@carpawell
Copy link
Member

tests.object.test_object_lock.TestObjectLockWithGrpc#test_expired_object_should_be_deleted_after_locks_are_expired tests.

Current Behavior

Got Failed: DID NOT RAISE <class 'Exception'> message if an object is not deleted.

Expected Behavior

Some understandable message about object not deleted after some time.

Possible Solution

Do some assert with a message. It is possible in pytest?

Steps to Reproduce

See https://rest.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/1441-1711487340/index.html#suites/295ed2e000f8fa6f3ade59cc13b98615/3f2b8cbfd27db081/

@carpawell carpawell added bug Something isn't working U3 Regular labels Mar 27, 2024
@carpawell
Copy link
Member Author

To be honest, I see SO MANY strange messages in reports so I am dreaming of creating a single issue "check all the error messages" but almost sure it will be rejected. But just imagine me creating 50 issues and writing 50 issue descriptions, will it be really effective?

@roman-khimov roman-khimov added S4 Routine I4 No visible changes labels Mar 27, 2024
@roman-khimov roman-khimov added the good first issue Good for newcomers label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers I4 No visible changes S4 Routine U3 Regular
Projects
None yet
Development

No branches or pull requests

2 participants