Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Some ContainerService.GetResponse fields are ignored #586

Open
cthulhu-rider opened this issue Jun 17, 2024 · 2 comments
Open

client: Some ContainerService.GetResponse fields are ignored #586

cthulhu-rider opened this issue Jun 17, 2024 · 2 comments
Labels
bug Something isn't working I4 No visible changes S3 Minimally significant U4 Nothing urgent

Comments

@cthulhu-rider
Copy link
Contributor

NeoFS API client ignores
https://github.com/nspcc-dev/neofs-api/blob/62e4ae0f8d62987cb54ab729b16b4f9ed4c0ad4c/container/service.proto#L215-L219

this is either:

  1. bug, and client must start to check these fields
  2. redundant information that should be eliminated from the protocol

i'd stand for 2 since fields are not returned, currently nobody is interested in verification info and is satisfied with the container presence

@cthulhu-rider cthulhu-rider added the bug Something isn't working label Jun 17, 2024
@cthulhu-rider cthulhu-rider transferred this issue from nspcc-dev/neofs-api Jun 17, 2024
@cthulhu-rider
Copy link
Contributor Author

same for GetExtendedACL

@roman-khimov
Copy link
Member

If it ended up in the contract, it can be considered valid, no need to check it additionally. But it's not trivial to remove now at the same time.

@roman-khimov roman-khimov added U4 Nothing urgent S3 Minimally significant I4 No visible changes labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working I4 No visible changes S3 Minimally significant U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants