Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish client refactor #537

Open
carpawell opened this issue Dec 15, 2023 · 1 comment
Open

Finish client refactor #537

carpawell opened this issue Dec 15, 2023 · 1 comment
Labels
enhancement Improving existing functionality good first issue Good for newcomers I4 No visible changes S2 Regular significance U3 Regular

Comments

@carpawell
Copy link
Member

carpawell commented Dec 15, 2023

Finish #323 work. I thought it was done but we still have non-object operations with client generalized context. In other words, contextCall should be removed. #323 proved that it does not save us from additional code, it even requires more code in fact. At the same time, it makes the code more complex: more additional structs, more anonymous funcs, callbacks, internal interfaces, etc.

@carpawell carpawell added good first issue Good for newcomers refactor labels Dec 15, 2023
@cthulhu-rider
Copy link
Contributor

@roman-khimov roman-khimov added enhancement Improving existing functionality I4 No visible changes U3 Regular S2 Regular significance and removed refactor labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality good first issue Good for newcomers I4 No visible changes S2 Regular significance U3 Regular
Projects
None yet
Development

No branches or pull requests

3 participants