Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control API passes addresses in stringified format #2980

Open
roman-khimov opened this issue Oct 25, 2024 · 0 comments
Open

Control API passes addresses in stringified format #2980

roman-khimov opened this issue Oct 25, 2024 · 0 comments
Labels
enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues S3 Minimally significant U4 Nothing urgent

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when I realize we have to parse addresses in control API just because we have string representations being used in the protocol.

Describe the solution you'd like

Use good old bytes, it's protobuf anyway. 32 for OID. 32 for CID. 64 for address.

Describe alternatives you've considered

Keeping as is, it works with some slight overhead.

Additional context

#2968
@roman-khimov roman-khimov added enhancement Improving existing functionality neofs-storage Storage node application issues U4 Nothing urgent S3 Minimally significant I4 No visible changes labels Oct 25, 2024
@roman-khimov roman-khimov mentioned this issue Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues S3 Minimally significant U4 Nothing urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roman-khimov