Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify status usage in storage engine when object is missing #2956

Open
carpawell opened this issue Oct 1, 2024 · 0 comments
Open

Unify status usage in storage engine when object is missing #2956

carpawell opened this issue Oct 1, 2024 · 0 comments
Labels
enhancement Improving existing functionality good first issue Good for newcomers I4 No visible changes S3 Minimally significant U4 Nothing urgent

Comments

@carpawell
Copy link
Member

carpawell commented Oct 1, 2024

Is your feature request related to a problem? Please describe.

I'm always frustrated when we have both bool flags that mean the presence of an object in the engine and ErrObjectNotFound. Sometimes it is a flag and sometimes it is an error.

Describe the solution you'd like

It should either be error, or be a flag.

Describe alternatives you've considered

-

Additional context

Sometimes it is ok to have an error and sometimes we only accept a flag, it is unreliable.
As for me, I wouldn't say I like using client statuses (that is where they are placed in SDK) in engines at all.

@roman-khimov roman-khimov added enhancement Improving existing functionality U0 Needs to be resolved immediately S3 Minimally significant I4 No visible changes U4 Nothing urgent and removed U0 Needs to be resolved immediately labels Oct 1, 2024
@cthulhu-rider cthulhu-rider added the good first issue Good for newcomers label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality good first issue Good for newcomers I4 No visible changes S3 Minimally significant U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

3 participants