Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what type of objects can be deleted #308

Open
carpawell opened this issue Oct 16, 2024 · 0 comments
Open

Clarify what type of objects can be deleted #308

carpawell opened this issue Oct 16, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U4 Nothing urgent
Milestone

Comments

@carpawell
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when I see some comments in implementation code cannot be proved by API references. E.g. we do not allow tombstone deletion, lock object deletion but I cannot find any words about it near Tombstone or Delete.

Describe the solution you'd like

Clarify that what exact is not possible to delete.

Describe alternatives you've considered

Keep as is, it allows some free space in implementations but also makes a dev sometimes do not understand how implement deletion code.

Additional context

https://github.com/nspcc-dev/neofs-node/blob/c4bdae16ab06a49349cc446f897dc00dc6420831/pkg/local_object_storage/metabase/inhume.go#L131-L132

@carpawell carpawell added I2 Regular impact feature Completely new functionality labels Oct 16, 2024
@roman-khimov roman-khimov added documentation Improvements or additions to documentation enhancement Improving existing functionality U4 Nothing urgent S3 Minimally significant I3 Minimal impact and removed I2 Regular impact feature Completely new functionality labels Oct 16, 2024
@roman-khimov roman-khimov added this to the v2.17.0 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants