You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AnnaShaleva
changed the title
Properly await WS connections finalization on server shutdown
Properly await WS connections finalization on RPC server shutdown
Nov 6, 2024
Current Behavior
Described in #3661 (comment). Stacktrace of improperly reused RPC server mutex shows that WS-handler routines are still active after server shutdown:
Expected Behavior
All goroutines spawned during Server's lifetime are properly finilized and awaited in the call to Server's
Shutdown()
.Possible Solution
It's not a critical bug, especially after #3661 merge, but we'd better keep the proper behaviour and await all WS-related routines in server shutdown.
The text was updated successfully, but these errors were encountered: