Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reupload existing blocks to NeoFS block storage #3652

Open
AnnaShaleva opened this issue Oct 29, 2024 · 0 comments
Open

Do not reupload existing blocks to NeoFS block storage #3652

AnnaShaleva opened this issue Oct 29, 2024 · 0 comments
Labels
cli Command line interface enhancement Improving existing functionality I4 No visible changes S4 Routine U3 Regular
Milestone

Comments

@AnnaShaleva
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently upload-bin finds latest incomplete batch of blocks and starts reuploading from the first block in this batch. Due to #3647 (comment) objects with the same block index but different OIDs may be created using this way of uploading.

Describe the solution you'd like

Don't upload the same block twice. Instead, search for the latest incomplete batch, then search for the missing block indexes in this batch and upload only missing blocks.

Describe alternatives you've considered

Leave it as is. It works, but a lot of useless duplicating objects are created which makes SEARCH request slower.

@AnnaShaleva AnnaShaleva added U3 Regular enhancement Improving existing functionality cli Command line interface S4 Routine I4 No visible changes labels Oct 29, 2024
@AnnaShaleva AnnaShaleva added this to the v0.106.4 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Command line interface enhancement Improving existing functionality I4 No visible changes S4 Routine U3 Regular
Projects
None yet
Development

No branches or pull requests

1 participant