Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring across updates to javascript-detect-element-resize #14

Open
benjeffery opened this issue Nov 27, 2015 · 2 comments
Open

Bring across updates to javascript-detect-element-resize #14

benjeffery opened this issue Nov 27, 2015 · 2 comments

Comments

@benjeffery
Copy link

There are a few commits such as sdecima/javascript-detect-element-resize@b058d39 which don't seem to be reflected in the code for this component.
Is there a reason for not using that module as a dependency?

Thanks!

@nrako
Copy link
Owner

nrako commented Nov 27, 2015

You are right good catch, it looks like opacity: 0 can prevent a bug in chrome.

//opacity:0 works around a chrome bug https://code.google.com/p/chromium/issues/detail?id=286360

This was committed by the PR author before I started this component but was released after https://github.com/sdecima/javascript-detect-element-resize/releases/tag/v0.5.2, so I probably never saw that.

I used javascript-detect-element-resize has a source of information at some point but that wasn't the original source for this component Daniel - backalleycoder.com, original blog post was. And after a quick look javascript-detect-element-resize doesn't look very suitable to be used as dependency. Moreover Dianel blog post solution changed quite a bit and I would rather try to implement his new solution which seems more elegant.

Unfortunately I don't have yet much more personal incentive to accelerate this change, and also since current implementation doesn't trigger much more issues I'm not in a hurry.

However feel free to point to more commits which you think should be included I'll happily do a quick release, even better a PR 😝 🙏

@benjeffery
Copy link
Author

Thanks! Ahhhh, I see now that you couldn't use that directly. Makes sense.
Will try and get a PR to you at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants