Feature [RM67] Detail View Short Description #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short descriptions are shown in cells instead of full descriptions if they are available.
Short description is shown with the full description when available.
| @@ -30,7 +34,12 @@ struct CharacterDetailView: View { | |||
|
|
|||
| struct CharacterDetailView_Previews: PreviewProvider { | |||
| static var previews: some View { | |||
| CharacterDetailView(character: ricks[0]) | |||
| CharacterDetailView(character: morties[0]) | |||
| NavigationView { | |||
Comment on lines
+21
to
+24
| VStack(alignment: .leading, spacing: 12) { | ||
| if let c = character as? ShortCharacterDescription { | ||
| Text(c.shortDescription) | ||
| } |
There was a problem hiding this comment.
This if this is a duplicated logic, IF there would be 3rd way of describing character, like fullDescription You would have fix this in 2 places in code. If the application would have more then those two, would you put that logic everywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/orgs/novoda/projects/1#card-66365504
The short and full descriptions are shown in the detail view when available.