New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markActive in keydbstore is not scalable #1702

Open

ctrlhxj opened this issue Mar 12, 2024 · 0 comments

ctrlhxj commented Mar 12, 2024

Code here: https://github.com/notaryproject/notary/blob/master/signer/keydbstore/sql_keydbstore.go#L195

It's not scalable since it's updating the same database row for every request in the same collection.

Since there is no need to mark it inactive, could we check if it's NULL first before we update it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment