-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pnpm dynamic task rule uses registers task instead of creating it #279
Comments
the reason for this is that right now the task is not created until task collection is asked to create it, because register is lazy by default. Right now, one have to overcome this issue by calling the "get" method on TaskProvider to create the real task and then it can be used in depends_on
the same for for example pnpm_run_test etc... |
On one hand this makes perfect sense and this absolutely shouldn't differ between the different tools The reasoning behind this is that the moment you want to depend on something then this is no longer an ad-hoc task being run, and ad-hoc tasks is what the rule is meant for By doing this you don't incur any cost for configuring the task if it's not being used, Gradle has lazy configuration but if we create the task instead of registering it we prevent it from being lazy I need to do some quick searches and see how these are being used in the wild, I can see why this is convenient and it might be that it should just be solved by proper documentation rather than artificial technical limitations |
The addPnpmRule should use the same logit as addNpmRule.
It should create (and not only register) the task.
The text was updated successfully, but these errors were encountered: