Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to Thoth.Json.Core #6

Open
joprice opened this issue Jul 29, 2024 · 1 comment
Open

migrate to Thoth.Json.Core #6

joprice opened this issue Jul 29, 2024 · 1 comment

Comments

@joprice
Copy link

joprice commented Jul 29, 2024

I tried out migrating to Thoth.Json.Core and it seems that Auto is the only missing piece master...joprice:thoth-json-codec:thoth-core. I changed things in place, but perhaps the code should just be copy pasted into a new folder named something like thoth-json-core-codec?

@njlr
Copy link
Owner

njlr commented Jul 29, 2024

Hi there 👋

I have a draft PR for auto support on top of the new Thoth.Json.Core: thoth-org/Thoth.Json#189
That would need to be merged before auto codecs can be implemented for the new Thoth.

My PR moves auto into a new package so that it is possible to use core Thoth without any reflection.

So I think a good approach here would be to have two packages here:

  • Thoth.Json.Codec
  • Thoth.Json.Auto.Codec

... or something like that.

I think it would also be great to roll this code into the main repo, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants