NDEV-17738 sort before chunking - 1.9

[pns-nirmata]

Explanation

Previously, large kyverno reports needed to be split into chunks, used to be refreshed frequently, generally once or so every minute.

Related issue

https://nirmata.atlassian.net/browse/NDEV-17738, and the original issue on Kyverno, kyverno#8520 (that has reproduce steps)

Milestone of this PR

1.95-n4k-nirmata.3

What type of PR is this

/kind bug

Proposed Changes

Earlier, we were sorting report results before creating the policyreport. This change sorts the results before chunking, so that we have a predictable sort order,

Proof Manifests

Tested this by first reproducing this defect on a kwok cluster as described in the original Kyverno ticket. And after fix, ensured that the kubectl -n ns-1 get polr -w does not continuously update.

Checklist

• I have read the contributing guidelines.
• I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
• This is a bug fix and I have added unit tests that prove my fix is effective.
• This is a feature and I have added CLI tests that are applicable.
• My PR needs to be cherry picked to a specific release branch which is .
• My PR contains new or altered behavior to Kyverno and
  • CLI support should be added and my PR doesn't contain that functionality.
  • I have added or changed the documentation myself in an existing PR and the link is:
  • I have raised an issue in kyverno/website to track the documentation update and the link is:

Further Comments

[pns-nirmata]

There are some test-cli failures, but these exist on the base release-1.9-n4k branch too. The 1.10 branch has no such failures. The changes are identical. (ref: #58)

[JimBugwadia]

Should we remove the sort here?

kyverno/pkg/utils/report/results.go

Line 174 in 033340b

SortReportResults(results)