Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception in render can cause react tree to unmount #695

Closed
mk opened this issue Oct 4, 2024 · 1 comment · Fixed by #698
Closed

Exception in render can cause react tree to unmount #695

mk opened this issue Oct 4, 2024 · 1 comment · Fixed by #698
Labels
next release Should be looked into before the next release

Comments

@mk
Copy link
Member

mk commented Oct 4, 2024

Noticed this as part of #694. Reverting the change from 16cb83e and rendering a Clojure doc with the following line comment caused the doc to unmount:

;; ```el
;; (define-key clojure-mode-map (kbd "<M-return>") 'clerk-show)
;; ```

I think I also noticed this in other situations. We should look into why the error boundary is not working as expected in this case.
@mk mk added the next release Should be looked into before the next release label Oct 4, 2024
@mk mk mentioned this issue Oct 7, 2024
Merged
@mk
Copy link
Member Author

mk commented Oct 7, 2024

Fixed with #698.

@mk mk closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next release Should be looked into before the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add react error boundaries for root and inspect-presented nextjournal/clerk
1 participant
@mk