Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[newrelic/helm-charts] Support sha256 for NewRelic Prometheus Configurator #1069

Open
quayly opened this issue Apr 19, 2023 · 2 comments
Open
Labels
bug Categorizes issue or PR as related to a bug. triage/pending Issue or PR is pending for triage and prioritization.

Comments

@quayly
Copy link

quayly commented Apr 19, 2023

Support sha256 for NewRelic Prometheus Configurator

In our environment, we use binary auth with the sha256 to verify the images for deployment

For example, in our yaml file, we have something like:
images:
configurator:
registry: "http://myurl/to/registry"
repository: newrelic/newrelic-prometheus-configurator
pullPolicy: IfNotPresent
tag: "1.2.0"
version: "1.2.0"

This works for environment that doesn't use binary auth.

However, for environment that uses binary auth, we have the following, it would fail.:
images:
configurator:
registry: "http://myurl/to/registry"
repository: newrelic/newrelic-prometheus-configurator
pullPolicy: IfNotPresent
tag: "1.2.0"
version: "1.2.0"
sha: 3d939e773cbed8fcff9d59f22b4efa4edc0f89daeedda946acab904ca6a12345

Is it possible to have the helm chart to check to see if the sha is available and use it? Thanks

@quayly quayly added bug Categorizes issue or PR as related to a bug. triage/pending Issue or PR is pending for triage and prioritization. labels Apr 19, 2023
@workato-integration
Copy link

@workato-integration
Copy link

Jira CommentId: 186738
Commented by epai:

this is a feature request. we would need to change our charts to make sha configurable at the very least and potentially add additional image signing in our build/release steps to support this. the work should be straight forward but we should still scope and prioritize it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug. triage/pending Issue or PR is pending for triage and prioritization.
Projects
None yet
Development

No branches or pull requests

1 participant