Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right menu does not display the current headings #58

Open
jcohenadad opened this issue Jun 23, 2022 · 1 comment · May be fixed by #67
Open

Right menu does not display the current headings #58

jcohenadad opened this issue Jun 23, 2022 · 1 comment · May be fixed by #67
Assignees

Comments

@jcohenadad
Copy link
Member

When clicking on a headings in the right TOC, the page goes at the correct headings, but the right TOC does not. See:

Screen.Recording.2022-06-23.at.9.57.00.AM.mov
@kousu
Copy link
Member

kousu commented Jun 23, 2022

Looks like it's just pages with subheadings. It looks like the right ToC is being synced via javascript based on the current y value on the page, not based on what's clicked (which makes sense), but its estimate is a bit off, and it's falling upwards, selecting the previous heading on for example all of these:

This would probably be avoided if we reconsidered #22, which has much simpler code and is designed to be easier to get right. For example, this sub-subheading (on a site using furo) jumps correctly:

@RignonNoel RignonNoel linked a pull request Jul 26, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants