Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseRelDir cannot be set to false in new netlify sites or change to true from older sites #5342

Open
kaovilai opened this issue Oct 19, 2023 · 7 comments
Labels
type: bug code to address defects in shipped code

Comments

@kaovilai
Copy link

kaovilai commented Oct 19, 2023

Describe the bug

baseRelDIr is not settable by end users of netlify causing new forks of a site created prior to 2019 to never be compatible with netlify.toml in the base directory.

Steps to reproduce

create new site from fork

Configuration

No response

Deploy logs

vmware-tanzu/velero#6981 (comment)

@kaovilai kaovilai added the type: bug code to address defects in shipped code label Oct 19, 2023
@kaovilai kaovilai changed the title baseRelDir cannot be set to false in new netlify sites baseRelDir cannot be set to false in new netlify sites or change to true from older sites Oct 19, 2023
@kaovilai
Copy link
Author

linking to github is promotional content wow

@biruwon
Copy link
Contributor

biruwon commented Oct 26, 2023

Can you try re-linking the repository to solve it for the old site? You can unlink and then link it again

@kaovilai
Copy link
Author

It would be preferable if new contributors are able to contribute without causing old site to make a change ideally.

What do you have against making it configurable?

Or even just have a "migrate to new behavior" button which create pull request and/or update UI settings to new relative dir behavior.

@kaovilai
Copy link
Author

Can you try re-linking the repository to solve it for the old site? You can unlink and then link it again

Do you know if this would be enough to trigger the change?

Copy link
Contributor

This issue has been automatically marked as stale because it has not had activity in 1 year. It will be closed in 14 days if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale label Oct 25, 2024
@kaovilai
Copy link
Author

@biruwon

re: Can you try re-linking the repository to solve it for the old site?

No. In any way you put it, relinking is breaking someone who is already forked it and had the old netlify config.. or new contributor forks break.

You need to make it configurable to make new contributors be able to link to old sites.. and vice versa.

@github-actions github-actions bot removed the stale label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

No branches or pull requests

2 participants