Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior between approval of faulty blueprints and allowing them to be cloned. #818

Open
nagygergo opened this issue Nov 6, 2024 · 2 comments
Labels
area/porch Porch related issues bug Something isn't working

Comments

@nagygergo
Copy link

nagygergo commented Nov 6, 2024

There is an inconsistency between being able to push propose and approve faulty packageRevisions and being able to clone them.
Either faulty packageRevisions should not be approvable, or it should be possible to clone faulty packagerevisions.

Steps to reproduce:

  1. Init porch package
  2. pull porch package
  3. modify a pulled package: add a kpt function with configuration that will fail
  4. push the modified porch package. You will face a function execution error.
  5. despite the faced issue the modified porch package was pushed to 'blueprints' repo; do its propose and approve
  6. check the modified porch package is in 'Published' state and its 'main' revision appeared
  7. clone 'Published' in 'blueprints' repo package to 'deployments' repo

Expected result: a cloned package appeared in 'deployments' repo, its status is 'Draft'
Actual result: a schema validation issue was faced again; any package was cloned to 'deployments' repo

@nagygergo nagygergo added bug Something isn't working area/porch Porch related issues labels Nov 6, 2024
@nagygergo
Copy link
Author

There is a case to be made for blueprint packages here that are partially done, so they can have their render result failing, but maybe this is not a valid case. Would need a wider community acceptance of either solutions before we can implement them. @kispaljr @liamfallon @efiacor

@nagygergo
Copy link
Author

This should only be applicable in case the kpt function was executed, and it returned an error, but in case the kpt functions were not able to execute, porch should not allow the next action (reject the change on the packageRevision with 500)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/porch Porch related issues bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant