You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is an inconsistency between being able to push propose and approve faulty packageRevisions and being able to clone them.
Either faulty packageRevisions should not be approvable, or it should be possible to clone faulty packagerevisions.
Steps to reproduce:
Init porch package
pull porch package
modify a pulled package: add a kpt function with configuration that will fail
push the modified porch package. You will face a function execution error.
despite the faced issue the modified porch package was pushed to 'blueprints' repo; do its propose and approve
check the modified porch package is in 'Published' state and its 'main' revision appeared
clone 'Published' in 'blueprints' repo package to 'deployments' repo
Expected result: a cloned package appeared in 'deployments' repo, its status is 'Draft'
Actual result: a schema validation issue was faced again; any package was cloned to 'deployments' repo
The text was updated successfully, but these errors were encountered:
There is a case to be made for blueprint packages here that are partially done, so they can have their render result failing, but maybe this is not a valid case. Would need a wider community acceptance of either solutions before we can implement them. @kispaljr@liamfallon@efiacor
This should only be applicable in case the kpt function was executed, and it returned an error, but in case the kpt functions were not able to execute, porch should not allow the next action (reject the change on the packageRevision with 500)?
There is an inconsistency between being able to push propose and approve faulty packageRevisions and being able to clone them.
Either faulty packageRevisions should not be approvable, or it should be possible to clone faulty packagerevisions.
Steps to reproduce:
Expected result: a cloned package appeared in 'deployments' repo, its status is 'Draft'
Actual result: a schema validation issue was faced again; any package was cloned to 'deployments' repo
The text was updated successfully, but these errors were encountered: