-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Vineflower Error-Handling #45
Comments
Is this still an issue with all the work that we did in this area? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If Vineflower runs out of memory, it'll skip a method and continue and ultimately return exit code 0, leading to an output.jar for which patching will fail (due to broken methods):
We probably need to make our handling of Vineflower more robust. This is just a marker issue to remember to do that.
Switching to the Vineflower API may improve our ability to handle this, but has other significant cost associated with it.
The text was updated successfully, but these errors were encountered: