From 5558472aa17b2b986ce6f442dca9ba180b19a82e Mon Sep 17 00:00:00 2001 From: Matyrobbrt Date: Tue, 10 Sep 2024 12:08:55 +0300 Subject: [PATCH] Warn for Modrinth maven too --- src/main/java/net/neoforged/moddevgradle/tasks/JarJar.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/main/java/net/neoforged/moddevgradle/tasks/JarJar.java b/src/main/java/net/neoforged/moddevgradle/tasks/JarJar.java index 56b48f79..0792bb92 100644 --- a/src/main/java/net/neoforged/moddevgradle/tasks/JarJar.java +++ b/src/main/java/net/neoforged/moddevgradle/tasks/JarJar.java @@ -111,6 +111,12 @@ protected void run() throws IOException { getLogger().warn("Embedding dependency {}:{}:{} from cursemaven using JiJ is likely to cause conflicts at runtime when other mods include the same library from a normal Maven repository.", includedJar.getGroup(), includedJar.getArtifact(), includedJar.getVersion()); } + // Same with the Modrinth official maven (see https://support.modrinth.com/en/articles/8801191-modrinth-maven) + // While actual versions can be used, version IDs (which are random strings) can also be used + else if ("maven.modrinth".equals(includedJar.getGroup())) { + getLogger().warn("Embedding dependency {}:{}:{} from Modrinth Maven using JiJ is likely to cause conflicts at runtime when other mods include the same library from a normal Maven repository.", + includedJar.getGroup(), includedJar.getArtifact(), includedJar.getVersion()); + } var originalName = includedJar.getFile().getName(); var embeddedName = includedJar.getEmbeddedFilename();