Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix published dependencies #37

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

lukebemish
Copy link
Contributor

There are two current issues with the jst-cli-bundle publication that result in wacky metadata. First, the shadow.component(...) method is used to add the shadow jar to the publication -- this approach does not, in fact, use a component, but just manually adds the artifact, and adds dependencies to the pom. This probably helped hide the actual issue a bit -- the actual issue being that shadowRuntimeElements.extendsFrom shadow within the shadow plugin itself, as the shadow plugin uses the shadow configuration to mean "things you're not bundling, and hence need to publish a dependency on". However, the jst-cli buildscript reuses this name for "things that should be bundled" and so the jst-cli-bundle published a dependency on everything it bundled. This PR fixes this, and uses a component for publishing so we get gradle module metadata.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Aug 13, 2024

  • Publish PR to GitHub Packages

Last commit published: 6e14bb4041ec32c3147b22f2616c45906fcf8830.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #37' // https://github.com/neoforged/JavaSourceTransformer/pull/37
        url 'https://prmaven.neoforged.net/JavaSourceTransformer/pr37'
        content {
            includeModule('net.neoforged.jst', 'jst-cli')
            includeModule('net.neoforged.jst', 'jst-cli-bundle')
            includeModule('net.neoforged.jst', 'jst-api')
        }
    }
}

cli/build.gradle Outdated Show resolved Hide resolved
@Technici4n Technici4n merged commit 660050a into neoforged:main Aug 13, 2024
2 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as JavaSourceTransformer version 1.0.64.

@lukebemish lukebemish deleted the fix-publishing branch August 13, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants