Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Designated native RoleManagement events with old/new public keys #3389

Closed
AnnaShaleva opened this issue Jul 2, 2024 · 1 comment · Fixed by #3397
Closed

Extend Designated native RoleManagement events with old/new public keys #3389

AnnaShaleva opened this issue Jul 2, 2024 · 1 comment · Fixed by #3397
Assignees
@shargon
Labels
discussion Initial issue state - proposed but not yet accepted

Comments

@AnnaShaleva
Copy link
Member

Summary or problem description
Issue migrated from #3386 (comment).

Designation RoleManagement events include only role and block height, whereas it would be useful for users to track the previous and updated set of designated public keys, exactly like it's done for CommitteeChanged events.

Do you have any solution you want to propose?
Extend Designation event with two arguments: old and new Arrays of public keys.

Where in the software does this update applies to?

  • Native contracts
@AnnaShaleva AnnaShaleva added the discussion Initial issue state - proposed but not yet accepted label Jul 2, 2024
@shargon shargon self-assigned this Jul 2, 2024
@shargon shargon mentioned this issue Jul 4, 2024
Merged
15 tasks
@cschuchardt88
Copy link
Member

completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shargon shargon

Labels
discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add entries to Designation event neo-project/neo
3 participants
@shargon @cschuchardt88 @AnnaShaleva