Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to enter arguments for deploy method in neo-one build command #2516

Open
spencercorwin opened this issue Jul 14, 2021 · 0 comments
Labels
area/cli Categorize issue or PR as cli (@neo-one/cli) related good first issue kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed.

Comments

@spencercorwin
Copy link
Collaborator

If a contract's deploy method (the constructor) has any required arguments then the build command won't work because it doesn't accept any arguments from the user like the deploy command does. The easy solution for the user is to either have no required args for constructor, or have default arguments for constructor just for testing, or to not use the build command and instead use the other CLI commands to do the same thing (start network, deploy, etc.)

The best solution is to have the build command prompt the user for arguments just like it does when using the deploy command, if there are any required args for deployment. So see code in runMigration.ts to see how we prompt the user for arguments

@spencercorwin spencercorwin added kind/feature Categorizes issue or PR as related to a new feature. good first issue area/cli Categorize issue or PR as cli (@neo-one/cli) related priority/important-longterm Important over the long term, but may not be staffed. labels Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Categorize issue or PR as cli (@neo-one/cli) related good first issue kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed.
Projects
None yet
Development

No branches or pull requests

1 participant