You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the findGitSlug method relies on two separate regexes for identifying a github.com or a GHE domain from a given repo URL.
Although findGitSlug returns either "CodeCommit", "GitHub" or "GitHubEnterprise" - this return value is never used elsewhere.
The code does not differentiate between github.com and GHE domain elsewhere, so a single regex is sufficient to extract both : ^https?://([^/]+)/(.+)/(.+?)(?:\.git)?$
If acceptable, I would be happy to make this fix and modify the tests.
The text was updated successfully, but these errors were encountered:
Currently, the
findGitSlug
method relies on two separate regexes for identifying agithub.com
or a GHE domain from a given repo URL.findGitSlug
returns either"CodeCommit"
,"GitHub"
or"GitHubEnterprise"
- this return value is never used elsewhere.github.com
and GHE domain elsewhere, so a single regex is sufficient to extract both :^https?://([^/]+)/(.+)/(.+?)(?:\.git)?$
If acceptable, I would be happy to make this fix and modify the tests.
The text was updated successfully, but these errors were encountered: