Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Upgrade to jdk 17 and SpringBoot 3.x #217

Merged

Conversation

omar-araboghli
Copy link

@omar-araboghli omar-araboghli commented Sep 9, 2023

Closes #216

I tried to cover as much as possible but there are still missing things. Maybe you guys could help.

  • I couldn't run the tests in /ngbatis-demo due to a org.nebula.contrib.ngbatis.exception.QueryException. Is there a certain config I should do when setting up the project ?
  • BeetlTextRenderTest.test2() is failing with following exception. Any help with that from your side ? I unfortunately couldn't know where that is originating from.
java.lang.reflect.InaccessibleObjectException: Unable to make public java.lang.Object java.util.Arrays$ArrayList.get(int) accessible: module java.base does not "opens java.util" to unnamed module @50b494a6

@1244453393
Copy link
Contributor

I tried to cover as much as possible but there are still missing things. Maybe you guys could help.

  • I couldn't run the tests in /ngbatis-demo due to a org.nebula.contrib.ngbatis.exception.QueryException. Is there a certain config I should do when setting up the project ?
  • BeetlTextRenderTest.test2() is failing with following exception. Any help with that from your side ? I unfortunately couldn't know where that is originating from.
java.lang.reflect.InaccessibleObjectException: Unable to make public java.lang.Object java.util.Arrays$ArrayList.get(int) accessible: module java.base does not "opens java.util" to unnamed module @50b494a6

springboot2.x is still supported?

@omar-araboghli
Copy link
Author

@1244453393, I never tested this but I don't think it's possible. At least without having additional considerations.

@1244453393
Copy link
Contributor

@1244453393, I never tested this but I don't think it's possible. At least without having additional considerations.

people who use the springboot2.x are still the majority

@omar-araboghli
Copy link
Author

people who use the springboot2.x are still the majority

What about maintaining two different releases ? It adds more efforts obviously but how would you else go with this issue internally ?

1 similar comment
@omar-araboghli
Copy link
Author

people who use the springboot2.x are still the majority

What about maintaining two different releases ? It adds more efforts obviously but how would you else go with this issue internally ?

@1244453393
Copy link
Contributor

people who use the springboot2.x are still the majority

What about maintaining two different releases ? It adds more efforts obviously but how would you else go with this issue internally ?

there is currently no great solution,but the version transition is not very fast,this gives us ample time to study how to upgrade to the new version!XD

@wey-gu wey-gu added RFC Proposal for change help wanted Extra attention is needed labels Sep 11, 2023
@CorvusYe
Copy link
Collaborator

My idea is that a new branch can be created. I'll probably have some time to try on springboot3.x this Wednesday, and then I'll take a look at the problems.

@CorvusYe
Copy link
Collaborator

CorvusYe commented Sep 12, 2023

@omar-araboghli

  • BeetlTextRenderTest.test2() is failing with following exception. Any help with that from your side ? I unfortunately couldn't know where that is originating from.

I may have found the root cause of the problem.

Run the following code, and the results differ between java8 and java17.
This place triggered this equivalent code.
Should the difference be in the handling of access permissions for private static internal classes in JDK?

Class.forName("java.util.Arrays$ArrayList").getMethod("get", int.class).setAccessible(true);

The param can't use Arrays.asList("name");
This is a problem with the test case itself

Copy link
Collaborator

@CorvusYe CorvusYe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omar-araboghli
I tried to work basically on Springboot3.x, with the exception of some of the original Array.asList test cases. Another use case that reads mapping relationships from PathWrapper is still misreporting, which is a functional flaw.

QueryException may be caused by the fact that the database does not have a schema that matches the test case.

At present, in addition to some conflicts, this PR has some codestyle problems to be solved.

It's possible to work properly. Thank you for your time.

I suggest creating another branch to be compatible with springboot3.x with a higher version number.

cc:@wey-gu

@CorvusYe CorvusYe mentioned this pull request Nov 21, 2023
@CorvusYe CorvusYe changed the base branch from master to for-jdk17 November 24, 2023 07:19
@CorvusYe CorvusYe changed the base branch from for-jdk17 to for-jdk17-resolve-conflicts November 24, 2023 11:54
@CorvusYe CorvusYe merged commit 19f99a3 into nebula-contrib:for-jdk17-resolve-conflicts Nov 24, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed RFC Proposal for change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading to SpringBoot 3.x
4 participants