feat: config file schema versioning #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucaLanziani
reviewed
Oct 2, 2023
LucaLanziani
reviewed
Oct 2, 2023
zaremba-tomasz
force-pushed
the
feat/config-file-schema-versioning
branch
4 times, most recently
from
1d9d69e
to
b4d40c4
Compare
zaremba-tomasz
force-pushed
the
feat/config-file-schema-versioning
branch
from
b4d40c4
to
bde6928
Compare
Comment on lines
+1
to
+4
| { | ||
| "cliVersion": "v0.5.0", | ||
| "configFileSchemaVersion": "v1" | ||
| } |
There was a problem hiding this comment.
@zaremba-tomasz just getting back to this, what's the reason to keep this in a json file and not in code?
|
Implementation has to be rewritten from the scratch, more details in the task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a config file schema versioning mechanism. The schema version is kept in the
versions.jsonfile and will be manually updated and needed. Each command of the CLI which works with.initium.yamlfile should compare the version within the file with the one embedded in the binary and decide whether it can proceed or not.Closes #116.