Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of Tests #131

Open
Hazboun6 opened this issue Sep 1, 2021 · 1 comment
Open

Lack of Tests #131

Hazboun6 opened this issue Sep 1, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Hazboun6
Copy link
Member

Hazboun6 commented Sep 1, 2021

There are very few tests for much of the functionality in this package. The current unit tests only cover about 30% of the code. Given that much of this code will be used in upcoming PTA analyses it seems worthwhile to try and round out the testing suite. An increase to above 50-60% would be very easy, just by testing the main classes within each of the files. Subpackages with less than 25% coverage include:

  • e_e.deterministic
  • e_e.dropout
  • e_e.empirical_distr
  • e_e.hypermodel
  • e_e.model_utils
  • e_e.sampler
  • e_e.sky_scrambles
  • e_e.frequentist.F_statitistic
  • e_e.frequentist.Fe_statitistic
  • e_e.chromatic.chromatic

At some point it would be nice to also incorporate more scientifically based tests, but we'll need to think carefully how to do that.

@Hazboun6 Hazboun6 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 1, 2021
@Hazboun6
Copy link
Member Author

Hazboun6 commented Sep 1, 2021

My feeling is that this would be a good project for students just starting to use our software stack. Building one test and learning how to submit a PR is a very useful set of coding skills.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant