Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing left_array in MarginalizingNmat.solve #401

Open
JacobCT opened this issue Sep 26, 2024 · 1 comment
Open

Missing left_array in MarginalizingNmat.solve #401

JacobCT opened this issue Sep 26, 2024 · 1 comment

Comments

@JacobCT
Copy link

JacobCT commented Sep 26, 2024 •
edited by vhaasteren
Loading

When trying to calculate the Fe statistic, we came into a problem located in the solve function (line 860) of gp_signals.py. When both the variables right and left_array are two-dimensional and are not the same, they are not covered by the elif conditions currently present.
@JacobCT JacobCT changed the title Modifications to gp_signals.py for Fe calculation and OS statistics Problem when using gp_signals.py for Fe calculation and OS statistics Sep 26, 2024
@JacobCT JacobCT mentioned this issue Sep 26, 2024
Draft
@vhaasteren vhaasteren changed the title Problem when using gp_signals.py for Fe calculation and OS statistics Missing left_array in MarginalizingNmat.solve Sep 27, 2024
@vhaasteren
Copy link
Member

Yes, I knew about this thing missing. Great that you are submitting a PR, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vhaasteren @JacobCT