Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PINTPulsar does not check for coordinate units #363

Open
NihanPol opened this issue Oct 5, 2023 · 3 comments · Fixed by #370
Open

PINTPulsar does not check for coordinate units #363

NihanPol opened this issue Oct 5, 2023 · 3 comments · Fixed by #370

Comments

@NihanPol
Copy link
Contributor

NihanPol commented Oct 5, 2023

I am trying to read in non-nanograv and non-PTA data, where the position of the pulsar is given in equatorial coordinates (as opposed to ecliptic coordinates used in nanograv), where RA is in units of hhmmss.

Then enterprise pulsar object does not check for units, assuming they are supplied in radians, which results in an incorrect position used for these pulsars.

@scottransom
Copy link
Member

facepalm

@vallis
Copy link
Collaborator

vallis commented Oct 5, 2023

Is this a PINT issue or enterprise? If PINT has these as astropy Quantity values with units, can you propose code to fix the problem?

@vhaasteren
Copy link
Member

vhaasteren commented Nov 30, 2023

This is fixed by #370.

However, note that we do need to pay more attention to units between tempo2 and PINT in general. The units of the designmatrix are not compatible yet either

@vhaasteren vhaasteren added the bug label Nov 30, 2023
@vhaasteren vhaasteren linked a pull request Nov 30, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants