Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove soft replacement for missing sksparse #258

Closed
jellis18 opened this issue Mar 21, 2021 · 3 comments
Closed

Remove soft replacement for missing sksparse #258

jellis18 opened this issue Mar 21, 2021 · 3 comments

Comments

@jellis18
Copy link
Contributor

jellis18 commented Mar 21, 2021

In two places there are try-except statements that try to import sksparse and replace it with scipy otherwise. This prints or logs a message but I think we should get rid of this and require sksparse.

Especially after #257 is merged and scikit-sparse becomes an official dependency

@vallis
Copy link
Collaborator

vallis commented Mar 23, 2021

I support requiring sksparse and not defaulting to scipy: it's too confusing to support sparse cholesky through different libraries. Please go ahead with a PR if you have the code ready.

@jellis18
Copy link
Contributor Author

@vallis I'll get to this soon. I was off last week, hence the burst of activity but now it may have to wait til the weekend.

@vallis
Copy link
Collaborator

vallis commented Apr 6, 2021

Solved by @jellis18 with #260

@vallis vallis closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants