Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of acor package runs into trouble with more recent Numpy versions #22

Open
Hazboun6 opened this issue Sep 1, 2021 · 4 comments
Open

Comments

@Hazboun6
Copy link
Member

Hazboun6 commented Sep 1, 2021

The acor package is no longer under active development and has seen recent issues (@svigeland @kdolum) with newer versions of Numpy. Currently the import used in PTMCMCSampler is inside a try except loop, owing to some of these issues.

There is a nice autocorrelation function inside of emcee and this has recently been used in enterprise_extensions as a replacement for acor.

@Hazboun6
Copy link
Member Author

Hazboun6 commented Sep 1, 2021

It is an open question whether we should require either package as requirement for the sampler, but requiring emcee would be a pretty light addition.

@AaronDJohnson
Copy link
Collaborator

@Hazboun6 is the license for emcee such that we can just hijack the autocorrelation calculation file and not have any extra requirements (with the proper credits given in the file)?

@paulray
Copy link
Member

paulray commented Apr 29, 2022

The docs should also note that acor should not be installed with pip install acor since the PyPI version is different than the current master. It must be installed with pip install git+https://github.com/dfm/acor.git to get the version that PTMCMCSampler wants.

@kdolum
Copy link
Collaborator

kdolum commented Apr 29, 2022

The docs should also note that acor should not be installed with pip install acor since the PyPI version is different than the current master. It must be installed with pip install git+https://github.com/dfm/acor.git to get the version that PTMCMCSampler wants.

This is a rather unpleasant situation, exacerbated by the fact that the two different versions of acor have the same version number. If would be nice to avoid this problem by not using it all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants