Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid buffering of the data when receiving it #773

Closed
2 tasks
dignifiedquire opened this issue Jan 12, 2023 · 4 comments
Closed
2 tasks

Avoid buffering of the data when receiving it #773

dignifiedquire opened this issue Jan 12, 2023 · 4 comments
Assignees

Comments

@dignifiedquire
Copy link
Contributor

  • Decoding should happen immediately, not when all the data is done
  • Don't send the outboard data separated, send it together with the data

Ref oconnor663/bao#44

@rklaehn
Copy link
Contributor

rklaehn commented Jan 13, 2023

Not sure I get the second part. You want to send the outboard data interleaved with the data? Why? It is not going to make the transfer any faster, and for the deltachat use case there is no benefit in having partial data faster.

@dignifiedquire
Copy link
Contributor Author

The second piece is about failing as early as possible. The interleaved version of the bao data allows for earlier verification, whereas in the current construction you could receive a large blob of outboard data, with no way to verify it.

@ramfox
Copy link
Contributor

ramfox commented Jan 20, 2023

depends on #754

@rklaehn
Copy link
Contributor

rklaehn commented Jan 30, 2023

Implemented in https://github.com/n0-computer/sendme/pull/70

We got our own async bao decoder, which we will use until there is some progress getting async support in bao itself.

@ramfox ramfox closed this as completed Feb 1, 2023
@dignifiedquire dignifiedquire transferred this issue from n0-computer/sendme-legacy Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants