From d846fbc3accb23c284e64090db61b079e3bf2e86 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EC=9A=B0=EC=9E=AC=EC=84=B1?= <62244471+whojes-toss@users.noreply.github.com> Date: Wed, 20 Mar 2024 00:07:47 +0900 Subject: [PATCH 1/2] fix: DefaultResultSetHandler memory waste #3113 --- .../ibatis/executor/resultset/DefaultResultSetHandler.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/apache/ibatis/executor/resultset/DefaultResultSetHandler.java b/src/main/java/org/apache/ibatis/executor/resultset/DefaultResultSetHandler.java index 6145d5c4cd4..01cc0361712 100644 --- a/src/main/java/org/apache/ibatis/executor/resultset/DefaultResultSetHandler.java +++ b/src/main/java/org/apache/ibatis/executor/resultset/DefaultResultSetHandler.java @@ -782,8 +782,9 @@ private Object applyConstructorAutomapping(ResultSetWrapper rsw, ResultMap resul private boolean applyColumnOrderBasedConstructorAutomapping(ResultSetWrapper rsw, List> constructorArgTypes, List constructorArgs, Constructor constructor, boolean foundValues) throws SQLException { - for (int i = 0; i < constructor.getParameterTypes().length; i++) { - Class parameterType = constructor.getParameterTypes()[i]; + Class[] parameterTypes = constructor.getParameterTypes(); + for (int i = 0; i < parameterTypes.length; i++) { + Class parameterType = parameterTypes[i]; String columnName = rsw.getColumnNames().get(i); TypeHandler typeHandler = rsw.getTypeHandler(parameterType, columnName); Object value = typeHandler.getResult(rsw.getResultSet(), columnName); From 926c451275908bccd0e25a4b57a02b9173739ad5 Mon Sep 17 00:00:00 2001 From: Iwao AVE! Date: Wed, 20 Mar 2024 06:05:31 +0900 Subject: [PATCH 2/2] Update license year --- .../ibatis/executor/resultset/DefaultResultSetHandler.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/apache/ibatis/executor/resultset/DefaultResultSetHandler.java b/src/main/java/org/apache/ibatis/executor/resultset/DefaultResultSetHandler.java index 01cc0361712..8cdc29d6377 100644 --- a/src/main/java/org/apache/ibatis/executor/resultset/DefaultResultSetHandler.java +++ b/src/main/java/org/apache/ibatis/executor/resultset/DefaultResultSetHandler.java @@ -1,5 +1,5 @@ /* - * Copyright 2009-2023 the original author or authors. + * Copyright 2009-2024 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.