Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing images #69

Closed
craigsapp opened this issue Feb 8, 2019 · 5 comments
Closed

missing images #69

craigsapp opened this issue Feb 8, 2019 · 5 comments
Assignees
Labels

Comments

@craigsapp
Copy link
Member

On the page:

https://music-encoding.org/guidelines/v4/content/usersymbols.html

There are six missing images,such as:

screen shot 2019-02-08 at 3 44 31 am

@bwbohl
Copy link
Member

bwbohl commented Mar 29, 2019

Figure contents was

<symbolDef xml:id="userSymbols.triangleSymbol3">
  <line x="0" x2="2.55" y="0" y2="4.25"/>
  <line x="2.55" x2="5.1" y="4.25" y2="0"/>
  <line x="5.1" x2="0.85" y="0" y2="0"/>
</symbolDef>

and

<symbolDef xml:id="userSymbols.triangleSymbolWithStick">
  <symbol ref="#userSymbols.triangleSymbol3"/>
  <line x="2.55" x2="5.95" y="1.25" y2="3.4"/>
</symbolDef>

how should this get back into the guidelines:
a) directly as codeblock as above?
b) via xml snippet in example file?

@musicEnfanthen
Copy link
Member

It seems that the section uses a wrong include snippet, trying to include (non-existing) figures instead of encoding samples, so

{% include figure img="" caption="Definition of a triangle percussion symbol using graphic primitives" %}

instead of

{% include mei example="usersymbols/usersymbols-sampleXXX.xml" valid="" %}

The encoding samples are here: https://github.com/music-encoding/guidelines/tree/master/_includes/v4/examples/usersymbols

@bwbohl
Copy link
Member

bwbohl commented Jul 31, 2019

@musicEnfanthen thx for spotting this, nevertheless the figures had been included in previous versions of the guidelines and I think they should be reintroduced, best both, code and figure. I'll see what I can do when fixing the new chapter 2 (cf. #81 )

@musicEnfanthen
Copy link
Member

Fully agree

@bwbohl bwbohl self-assigned this Aug 12, 2019
@rettinghaus
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants