You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The bundled plugins/node.d.netbsd/irqstats.in for munin-2.0.69 produces incorrect output the includes the value
of an entry into the name of the entry, causing copious amounts of unique entries to appear. Was found when I was
wondering exactly why munin would (rapidly) consume 8+GB for < 100 nodes. This bug easily creates 10k+ files
in a few days because of that. Oh, and of course the data is utterly useless as well for the same reason.
The faulty output looks like this (short excerpt only):
To Reproduce
Steps to reproduce the behavior:
Invoke the irqstats plugin on a sufficiently (observed with at least NetBSD 9.0, but I'm pretty sure I saw
it on earlier ones too) NetBSD machine (reproduced on: i386, amd64, sparc64), see the output:
Screenshots & Logs
If applicable, please add screenshots and/or logs to help explain your problem.
Desktop (please complete the following information):
OS: NetBSD 9.1, NetBSD 9.2, NetBSD 9.3
Munin version: 2.0.69
Additional context
I've been running a rewritten version of the irqstats plugin for NetBSD for ... a few months at least now, this
one works and produces the expected output:
#! /bin/sh## Plugin to monitor the individual interrupt sources.## Usage: Link or copy into /etc/munin/node.d/## $Log: irqstats.in,v $# Revision 1.1.1.1 2006/06/04 20:53:57 he# Import the client version of the Munin system monitoring/graphing# tool -- project homepage is at http://munin.sourceforge.net/## This package has added support for NetBSD, via a number of new plugin# scripts where specific steps needs to be taken to collect information.## I also modified the ntp_ plugin script to make it possible to not# plot the NTP poll delay, leaving just jitter and offset, which IMO# produces a more telling graph.#### Magic markers (optional - only used by munin-config and some# installation scripts):##%# family=auto#%# capabilities=autoconfif [ "$1"="autoconf" ];thenif [ -x /usr/bin/vmstat ];thenecho yes
exit 0
elseecho no
exit 1
fifi
intr_sources=$(/usr/bin/vmstat -i|grep -v Total|grep -v 'total rate'|sed -E 's/ {2,}/|/g'|sed 's/ /_/g'|grep -e '[:alnum:]'|cut -d\| -f1)echo"intr_sources = |$intr_sources|"# If run with the "config"-parameter, give out information on how the# graphs should look.if [ "$1"="config" ];thenecho'graph_title Individual interrupts'echo'graph_args --base 1000 -l 0'echo'graph_vlabel interrupts / ${graph_period}'echo'graph_category system'echo -n 'graph_order 'foriin$intr_sources;doecho -n ' intr_'${i}doneechoforiin$intr_sources;do# echo 'intr_'${i}'.draw LINE'echo'intr_'${i}'.label'`echo $i| sed -e 's/_/ /g'`echo'intr_'${i}'.info Interrupt'`echo $i| sed -e 's/_/ /g'`echo'intr_'${i}'.type DERIVE'echo'intr_'${i}'.min 0'doneexit 0
fi
/usr/bin/vmstat -i|grep -v Total|grep -v 'total rate'|sed -E 's/ {2,}/|/g'|sed 's/ /_/g'|sed 's/|/ /g'|grep -E '[:alnum:]'|awk '{print $1 ".value " $2}'
The text was updated successfully, but these errors were encountered:
wip-sync
pushed a commit
to NetBSD/pkgsrc-wip
that referenced
this issue
May 11, 2023
Copy the current state of sysutils/munin-node from pkgsrc as
prep for working on the package to locally fix the irqstats bug,
upstream: munin-monitoring/munin#1537
Signed-off-by: Alexander Schreiber <[email protected]>
wip-sync
pushed a commit
to NetBSD/pkgsrc-wip
that referenced
this issue
May 11, 2023
The munin-node irqstats plugin produces invalid data by incorporating
the field value into the field name, leading to all kinds of annoyances
upstream bug: munin-monitoring/munin#1537
Signed-off-by: Alexander Schreiber <[email protected]>
Describe the bug
The bundled plugins/node.d.netbsd/irqstats.in for munin-2.0.69 produces incorrect output the includes the value
of an entry into the name of the entry, causing copious amounts of unique entries to appear. Was found when I was
wondering exactly why munin would (rapidly) consume 8+GB for < 100 nodes. This bug easily creates 10k+ files
in a few days because of that. Oh, and of course the data is utterly useless as well for the same reason.
The faulty output looks like this (short excerpt only):
The expected output would be this:
To Reproduce
Steps to reproduce the behavior:
Invoke the irqstats plugin on a sufficiently (observed with at least NetBSD 9.0, but I'm pretty sure I saw
it on earlier ones too) NetBSD machine (reproduced on: i386, amd64, sparc64), see the output:
Expected behavior
Expected output would look like this:
Screenshots & Logs
If applicable, please add screenshots and/or logs to help explain your problem.
Desktop (please complete the following information):
OS: NetBSD 9.1, NetBSD 9.2, NetBSD 9.3
Munin version: 2.0.69
Additional context
I've been running a rewritten version of the irqstats plugin for NetBSD for ... a few months at least now, this
one works and produces the expected output:
The text was updated successfully, but these errors were encountered: